fix: resolve permission fallback bug, remove debug code, and cleanup duplication
Logic Errors ------------ - Sidebar: fix permissions fallback so a user with no permissions gets zero access instead of falling back to the full nav list (user?.permissions ?? [] instead of ?? navSections.flatMap(...)) - carMaintanance.service / UseCarsMaintanance: add pagination to the maintenance records fetch instead of loading the entire list at once - api.ts: redact sensitive fields (password, token) before logging the request body in console.debug, to avoid leaking credentials/PII Code Flow Problems ------------------- - OrderFormModal: remove leftover console.log/debug statements and the redundant onClick handler on the submit button - auth: remove the unused src/service/auth.service.ts (axios) and keep only src/services/auth.service.ts (fetch); fix useAuth.ts import path from
This commit is contained in:
@@ -31,10 +31,8 @@ export default function ArchivedTripDetailPage() {
|
||||
setError(null);
|
||||
try {
|
||||
const token = getStoredToken();
|
||||
// Archived trips must go through the archived endpoint —
|
||||
// the normal /trip/:id endpoint won't return soft-deleted trips.
|
||||
const res = await tripService.getArchivedById(tripId, token);
|
||||
if (!cancelled) setTrip((res as unknown as { data: Trip }).data);
|
||||
const data = await tripService.getArchivedById(tripId, token);
|
||||
if (!cancelled) setTrip(data);
|
||||
} catch {
|
||||
if (!cancelled) setError("لم يتم العثور على هذه الرحلة في الأرشيف.");
|
||||
} finally {
|
||||
@@ -54,7 +52,6 @@ export default function ArchivedTripDetailPage() {
|
||||
);
|
||||
}
|
||||
|
||||
// Edge case: invalid/missing/unreachable trip ID
|
||||
if (error || !trip) {
|
||||
return (
|
||||
<EmptyState
|
||||
|
||||
Reference in New Issue
Block a user